NOISSUE - Add optional Filename #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
WashingtonKK
requested changes
Aug 8, 2024
There was a problem hiding this comment.
I am still able to upload a file with a different file name successfuily, without any error.
➜ cocos git:(filename) ✗ ./build/cocos-cli data test/manual/data/iris.csv private.pem
2024/08/08 17:27:25 Uploading dataset CSV: test/manual/data/iris.csv
Uploading data... 100% [============================================================================================================>]
2024/08/08 17:27:25 Successfully uploaded dataset
WashingtonKK
reviewed
Aug 9, 2024
WashingtonKK
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature as it adds filename to datasets which are optionally verified if specified on the manifest. Filename is also persisted on dataset directory
What does this do?
New Features
Bug Fixes
Chores
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
No
Notes
sequenceDiagram participant User participant ManagerService participant AgentService participant Dataset User->>ManagerService: Initiate computation run ManagerService->>AgentService: Prepare manifest containing datasets with Filename AgentService->>Dataset: Append new dataset with Filename to manifest User->>AgentService:Upload dataset AgentService->>Dataset:Verify filename as in manifest Dataset->>AgentService:Dataset stored with its filename AgentService-->>User: Datasets uploaded successfully