PRISM-312 : Fetch Backend Information #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> WIP Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> revert changes in test server Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update protoc Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
SammyOina
requested changes
Jul 31, 2024
manager/service.go
Outdated
| Value uint32 `json:"value"` | ||
| } | ||
|
|
||
| type SnpPolicy struct { |
There was a problem hiding this comment.
why not use https://github.com/google/go-sev-guest/blob/00148f763a981a74331226d462983bd9e9b903c4/proto/check/check.pb.go#L44 since it is already defined
manager/service.go
Outdated
| RequireIDBlock bool `json:"require_id_block"` | ||
| } | ||
|
|
||
| type RootOfTrust struct { |
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
SammyOina
requested changes
Aug 1, 2024
manager/service.go
Outdated
| } | ||
|
|
||
| func (ms *managerService) FetchBackendInfo() ([]byte, error) { | ||
| cmd := exec.Command("sudo", "../../scripts/backend_info/backend_info", "--policy", "1966081") |
There was a problem hiding this comment.
should be an env variable, and the default should be in the build dir as other bins. Also sudo is not required
There was a problem hiding this comment.
also remove the orignal /test/computation file
SammyOina
requested changes
Aug 1, 2024
manager/service.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| f, err := os.ReadFile("./scripts/backend_info/backend_info.json") |
There was a problem hiding this comment.
path should be relative to location of the backend_info bin
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
SammyOina
requested changes
Aug 1, 2024
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
SammyOina
approved these changes
Aug 1, 2024
SammyOina
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged with: https://github.com/ultravioletrs/prism/pull/398