-
Notifications
You must be signed in to change notification settings - Fork 12
COCOS-143 - Add agent service tests #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6652672
Add agent service tests
smithjilks 3f4dbbd
Update agent service tests
smithjilks 018077b
Fix agent service tests
smithjilks 04b21e3
Improve agent service test coverage
smithjilks 69f5722
Improve agent service test coverage
smithjilks e536080
Fix tests
smithjilks fa4bdb9
Refactor and improve coverage
smithjilks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,6 +55,8 @@ var ( | |
ErrFileNameMismatch = errors.New("malformed data, filename does not match manifest") | ||
// ErrAllResultsConsumed indicates all results have been consumed. | ||
ErrAllResultsConsumed = errors.New("all results have been consumed by declared consumers") | ||
// ErrAttestationFailed attestation failed. | ||
ErrAttestationFailed = errors.New("failed to get raw quote") | ||
) | ||
|
||
// Service specifies an API that must be fullfiled by the domain service | ||
|
@@ -124,7 +126,7 @@ func (as *agentService) Algo(ctx context.Context, algo Algorithm) error { | |
return fmt.Errorf("error getting current directory: %v", err) | ||
} | ||
|
||
f, err := os.Create(filepath.Join(currentDir, "algorithm")) | ||
f, err := os.Create(filepath.Join(currentDir, "algo")) | ||
if err != nil { | ||
return fmt.Errorf("error creating algorithm file: %v", err) | ||
} | ||
|
@@ -317,8 +319,9 @@ func (as *agentService) runComputation() { | |
} | ||
|
||
func (as *agentService) publishEvent(status string, details json.RawMessage) func() { | ||
st := as.sm.GetState().String() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolves race condition previously caused by access state directly |
||
return func() { | ||
if err := as.eventSvc.SendEvent(as.sm.State.String(), status, details); err != nil { | ||
if err := as.eventSvc.SendEvent(st, status, details); err != nil { | ||
as.sm.logger.Warn(err.Error()) | ||
} | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this change done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fail because algorithm dir already exists in the code base