+
Skip to content

Conversation

pyrello
Copy link
Contributor

@pyrello pyrello commented Jan 20, 2023

To test

yarn storybook
  • Verify no deprecation warnings.

@pyrello pyrello requested a review from a team January 20, 2023 18:13
@pyrello pyrello added the dx Developer experience improvements. label Jan 20, 2023
@GaryRidgway
Copy link
Contributor

Sheesh, this was stupid. I had to remove divides as well because they were depreciated in whatever version of sass that Sitenow was using. So i just wrote my own.

@bspeare
Copy link
Contributor

bspeare commented Jan 23, 2023

Let's make sure we update these once it is moved to uids_base: https://github.com/uiowa/uiowa/search?q=containerClamp.

Copy link
Contributor

@bspeare bspeare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like the expected values. Code reviewed, not tested. Let's not forget #853 (comment) and also updating the 3.x branch?

@pyrello pyrello merged commit c070d58 into 4.x Jan 23, 2023
@pyrello pyrello deleted the fix_sass_issues branch January 23, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dx Developer experience improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载