+
Skip to content

Conversation

pyrello
Copy link
Contributor

@pyrello pyrello commented Apr 6, 2022

Related to #671

To preview

https://uids.brand.uiowa.edu/branches/setup_4x/

To test

  • yarn
  • yarn storybook
  • http://localhost:6006/
  • Review the button and headline components and provide any feedback you may have.

@pyrello pyrello added the 4.x 4.x version label Apr 6, 2022
pyrello added 25 commits April 6, 2022 13:15
…ed it in index.html. Updated application to display the banner.
@pyrello pyrello marked this pull request as ready for review May 12, 2022 16:15
@pyrello pyrello requested a review from a team May 12, 2022 16:16
Copy link
Contributor

@GaryRidgway GaryRidgway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing is standing out to me as something we need to radically change, this looks good for now and I think that it is a good starting point to allow the icon browser to use it.

@pyrello
Copy link
Contributor Author

pyrello commented May 12, 2022

Thanks for the review and trying to solve the SB/Vue slot weirdness!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.x 4.x version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载