Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
This is an extension to the filtering features for the guppy graphql endpoint. Guppy historically supported only the “IN” query so a filter if any of the value selected is contained in the data or the “!=” so if any value of the data is in the selected list the data point is excluded. I called for clarity the former ‘CONTAINS_ANY’ and the latter ‘EXCLUDES_ANY’. (
guppy/src/server/es/filter.js
Lines 63 to 141 in 7792237
I would like to add the ‘CONTAINS_ALL
, so all the value selected have to be contained in the data for it to match, and the
EXCLUDES_ALL` to exclude a record only if all the selected values are present in the data.TEMPLATE - Gen3 Community Feature Document (template v1.1).docx
logic high level summary:
CONTAINS_ANY
:CONTAINS_ALL
:EXCLUDES_ANY
:EXCLUDES_ALL
: