+
Skip to content

PD-3 Fix/deeply nested array #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 18, 2025
Merged

PD-3 Fix/deeply nested array #329

merged 8 commits into from
Sep 18, 2025

Conversation

mfshao
Copy link
Contributor

@mfshao mfshao commented Aug 12, 2025 •
edited
Loading

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/PD-3

New Features

  • Guppy can now correctly handle querying deeply nested array field values

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

  • For deeply nested array fields, ETL needs to ensure its full path is correctly generated in the array config index (for example, visits.treatments_array_under_subjects.test_article_name_array_under_treatments instead of just test_article_name_array_under_treatments), otherwise Guppy will not be able to handle it correctly

@github-actions GitHub Actions
Copy link

filepath passed SUBTOTAL
tests/test_dicom_viewer.py 4 4
tests/test_pfb_export.py 1 1
tests/test_guppy_service.py 8 8
TOTAL 13 13

Please find the detailed integration test report here (login here first)

@github-actions GitHub Actions
Copy link

filepath passed SUBTOTAL
tests/test_dicom_viewer.py 4 4
tests/test_pfb_export.py 1 1
tests/test_guppy_service.py 8 8
TOTAL 13 13

Please find the detailed integration test report here (login here first)

@mfshao mfshao changed the title Fix/deeply nested array PD-3 Fix/deeply nested array Aug 18, 2025
@github-actions GitHub Actions
Copy link

filepath passed SUBTOTAL
tests/test_dicom_viewer.py 4 4
tests/test_pfb_export.py 1 1
tests/test_guppy_service.py 8 8
TOTAL 13 13

Please find the detailed integration test report here

@mfshao mfshao marked this pull request as ready for review August 28, 2025 16:00
jacob50231
jacob50231 approved these changes Sep 5, 2025
View reviewed changes
Copy link

@jacob50231 jacob50231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes look good to me as long as tube/ETL stuff works under testing.

@mfshao mfshao merged commit cffe0a6 into master Sep 18, 2025
9 checks passed
@mfshao mfshao deleted the fix/deeply-nested-array branch September 18, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacob50231 jacob50231 jacob50231 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mfshao @jacob50231
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载