+
Skip to content

Feat/es7 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 8, 2023
Merged

Feat/es7 #200

merged 15 commits into from
Nov 8, 2023

Conversation

thanh-nguyen-dang
Copy link
Contributor

@thanh-nguyen-dang thanh-nguyen-dang commented Jun 22, 2023

Jira Ticket: PXP-10748

New Features

Breaking Changes

  • Any environment using ElasticSearch 6.x will break with the new version

Bug Fixes

Improvements

Dependency updates

Deployment changes

  • We need to upgrade the target environment to use ElasticSearch 7.10 or OpenSearch before using this new guppy.
  • We also need to upgrade Tube to new version that is compatible with ES7. Checking this link for the corresponding PR of Tube.

@ocshawn
Copy link
Contributor

ocshawn commented Jun 29, 2023

when attempting to run:
GUPPY_PORT=3000 INTERNAL_LOCAL_TEST=true npm start
i get the following error:

[09:22:25] INFO: [ES.initialize] getting array fields from es config index "gen3-dev-config"...
[09:22:25] ERROR: [ES.initialize] wrong array entry from config index: index "gen3-dev-subject" not found, skipped.
[09:22:25] ERROR: [ES.initialize] wrong array entry from config index: index "gen3-dev-file" not found, skipped.
[09:22:25] INFO: [ES.initialize] got array fields from es config index: {}
/var/git/guppy/src/server/schema.js:73
  const result = Object.keys(properties).map((field) => {
                        ^

TypeError: Cannot convert undefined or null to object

this is after re running setup as defined in https://github.com/uc-cdis/guppy/blob/master/devHelper/README.md#step3-start-server-for-developing-server-side-code

@thanh-nguyen-dang
Copy link
Contributor Author

when attempting to run: GUPPY_PORT=3000 INTERNAL_LOCAL_TEST=true npm start i get the following error:

[09:22:25] INFO: [ES.initialize] getting array fields from es config index "gen3-dev-config"...
[09:22:25] ERROR: [ES.initialize] wrong array entry from config index: index "gen3-dev-subject" not found, skipped.
[09:22:25] ERROR: [ES.initialize] wrong array entry from config index: index "gen3-dev-file" not found, skipped.
[09:22:25] INFO: [ES.initialize] got array fields from es config index: {}
/var/git/guppy/src/server/schema.js:73
  const result = Object.keys(properties).map((field) => {
                        ^

TypeError: Cannot convert undefined or null to object

this is after re running setup as defined in https://github.com/uc-cdis/guppy/blob/master/devHelper/README.md#step3-start-server-for-developing-server-side-code

You need to use ES7. I think you local ES is @ocshawn

@ocshawn
Copy link
Contributor

ocshawn commented Jun 29, 2023

i ran this command docker-compose -f ./devHelper/docker/esearch.yml up -d

it looks like that file sets up an old version, please update

@thanh-nguyen-dang
Copy link
Contributor Author

i ran this command docker-compose -f ./devHelper/docker/esearch.yml up -d

it looks like that file sets up an old version, please update

I fixed the docker compose issue @ocshawn . Thanks for letting me know the issue

ocshawn
ocshawn previously approved these changes Jun 30, 2023
Copy link
Contributor

@ocshawn ocshawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, i only tested locally; setup and storybook look and work great

please fill out PR details if this is a breaking change and any deployment details that are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载