+
Skip to content

(PXP-9147): add Count support to guppy connectedFilter and fix bugs #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 19, 2023
Merged

(PXP-9147): add Count support to guppy connectedFilter and fix bugs #180

merged 18 commits into from
May 19, 2023

Conversation

ocshawn
Copy link
Contributor

@ocshawn ocshawn commented May 9, 2023 •
edited
Loading

Jira Ticket: PXP-9147

New Features

  • add _totalCount to guppy items
  • remove unneeded countFields and extraAggsFieldsCardinalityCount property

Bug Fixes

  • fix performance bug where charts were being processed as filters, now only processes filters

@ocshawn ocshawn marked this pull request as ready for review May 9, 2023 19:56
@ocshawn ocshawn mentioned this pull request May 9, 2023
Closed
@ocshawn ocshawn requested a review from mfshao May 9, 2023 20:21
@ocshawn ocshawn marked this pull request as draft May 11, 2023 16:29
@ocshawn ocshawn changed the title (PPS-69): add cardinalityCount support to guppy connectedFilter and fix bugs (PPS-69): add Count support to guppy connectedFilter and fix bugs May 11, 2023
@ocshawn ocshawn changed the title (PPS-69): add Count support to guppy connectedFilter and fix bugs (PXP-9147): add Count support to guppy connectedFilter and fix bugs May 11, 2023
@ocshawn ocshawn marked this pull request as ready for review May 11, 2023 20:10
@ocshawn ocshawn mentioned this pull request May 11, 2023
Merged
@ocshawn
Copy link
Contributor Author

ocshawn commented May 12, 2023

closing will reopen when ready

@ocshawn ocshawn closed this May 12, 2023
@ocshawn ocshawn reopened this May 12, 2023
@ocshawn ocshawn marked this pull request as draft May 12, 2023 21:31
@ocshawn ocshawn marked this pull request as ready for review May 15, 2023 15:56
@ocshawn
Copy link
Contributor Author

ocshawn commented May 15, 2023

loaded to QA https://qa-ibd.planx-pla.net/explorer and ready for review

@ocshawn
Copy link
Contributor Author

ocshawn commented May 18, 2023

@mfshao please review, code is in QA https://qa-ibd.planx-pla.net/explorer and ready for review

@ocshawn ocshawn requested a review from thanh-nguyen-dang May 18, 2023 15:24
mfshao
mfshao reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes make sense to me, some minor comments

@ocshawn ocshawn requested a review from mfshao May 19, 2023 14:38
mfshao
mfshao approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ocshawn ocshawn merged commit a641ce4 into master May 19, 2023
@ocshawn ocshawn deleted the feat/cardinalityCount branch May 19, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfshao mfshao mfshao approved these changes

@thanh-nguyen-dang thanh-nguyen-dang Awaiting requested review from thanh-nguyen-dang

Assignees
No one assigned
Labels
@requires-guppy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocshawn @mfshao
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载