+
Skip to content

CMake: Fix wrong MSVC related conditions #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

CMake: Fix wrong MSVC related conditions #981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,14 @@ set(H3_COMPILE_FLAGS "")
set(H3_LINK_FLAGS "")
option(ENABLE_WARNINGS "Enables compiler warnings" ON)
if(ENABLE_WARNINGS)
if(WIN32)
if(MSVC)
list(APPEND H3_COMPILE_FLAGS /W2)
else()
list(APPEND H3_COMPILE_FLAGS -Wall)
endif()
endif()

if(NOT WIN32)
if(NOT MSVC)
# Compiler options are set only on non-Windows, since these options are not
# correct for MSVC.
list(
Expand All @@ -134,7 +134,7 @@ endif()

option(WARNINGS_AS_ERRORS "Warnings are treated as errors" OFF)
if(WARNINGS_AS_ERRORS)
if(WIN32)
if(MSVC)
list(APPEND H3_COMPILE_FLAGS /WX)
else()
list(APPEND H3_COMPILE_FLAGS -Werror)
Expand Down
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载