-
Notifications
You must be signed in to change notification settings - Fork 512
H3 4.0.0 Part 1: Renaming otherwise unchanged functions #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6dcbf30
9cf759d
6fc012f
bfe1ba6
a6e55e9
b385f11
ab7094a
ab8fd03
eedb812
9de32bb
fa75214
b59b2ff
491de72
421ad74
3e07223
260110f
29c3363
4283798
1a38c97
e672d79
9e91fbb
6e3c2a0
1f99d6b
bd6171e
ed7fa00
8b9e79d
f634ab8
4e2f44c
cbd4c63
2bed242
4769e72
e5606e7
554c1d7
d0e017d
7257492
01582e2
c509d42
51b3ff9
486cc6e
741d705
ea05df3
e14e7ab
1d9a4f0
a021943
6763b88
62eebdc
04910c2
1f6a7e4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/* | ||
* Copyright 2018 Uber Technologies, Inc. | ||
* Copyright 2018, 2020 Uber Technologies, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
|
@@ -35,7 +35,7 @@ int main(int argc, char* argv[]) { | |
printf("Starting with %d indexes.\n", inputSize); | ||
|
||
H3Index* compacted = calloc(inputSize, sizeof(H3Index)); | ||
int err = compact(input, compacted, inputSize); | ||
int err = compactCells(input, compacted, inputSize); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had forgotten all about the example files - do these not need There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They use H3 as a library, so |
||
// An error case can occur on e.g. duplicate input. | ||
assert(err == 0); | ||
|
||
|
@@ -50,10 +50,11 @@ int main(int argc, char* argv[]) { | |
printf("Compacted to %d indexes.\n", compactedCount); | ||
|
||
int uncompactRes = 10; | ||
int uncompactedSize = maxUncompactSize(compacted, inputSize, uncompactRes); | ||
int uncompactedSize = | ||
maxUncompactCellsSize(compacted, inputSize, uncompactRes); | ||
H3Index* uncompacted = calloc(uncompactedSize, sizeof(H3Index)); | ||
int err2 = uncompact(compacted, compactedCount, uncompacted, | ||
uncompactedSize, uncompactRes); | ||
int err2 = uncompactCells(compacted, compactedCount, uncompacted, | ||
uncompactedSize, uncompactRes); | ||
// An error case could happen if the output array is too small, or indexes | ||
// have a higher resolution than uncompactRes. | ||
assert(err2 == 0); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest leaving the names of the filters as-is and they can be refactored in a subsequent PR. I don't think this needs to be removed from this PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isaacbrodsky Could you make a follow-up issue? Or is this covered by #415?