+
Skip to content

xargs: Implement replace / -I (Closes: #310) #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 3, 2024
Merged

xargs: Implement replace / -I (Closes: #310) #323

merged 9 commits into from
Apr 3, 2024

Conversation

sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Feb 25, 2024 •
edited
Loading

Closes: #310

@codecov Codecov
Copy link

codecov bot commented Feb 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.07018% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 58.36%. Comparing base (274d749) to head (45c1938).

Files Patch % Lines
tests/xargs_tests.rs 72.22% 0 Missing and 20 partials ⚠️
src/xargs/mod.rs 88.09% 2 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   58.12%   58.36%   +0.23%     
==========================================
  Files          30       30              
  Lines        3630     3713      +83     
  Branches      821      841      +20     
==========================================
+ Hits         2110     2167      +57     
- Misses       1220     1223       +3     
- Partials      300      323      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre force-pushed the replace branch 2 times, most recently from ed2cbe6 to 3319bda Compare February 25, 2024 17:49
@sylvestre sylvestre requested a review from cakebaker February 25, 2024 18:02
cakebaker
cakebaker reviewed Feb 26, 2024
View reviewed changes
@sylvestre sylvestre requested a review from cakebaker February 27, 2024 10:26
cakebaker
cakebaker reviewed Feb 27, 2024
View reviewed changes
tertsdiepraam
tertsdiepraam reviewed Mar 7, 2024
View reviewed changes
@sylvestre sylvestre changed the title Implement replace xargs: Implement replace Mar 24, 2024
@sylvestre sylvestre changed the title xargs: Implement replace xargs: Implement replace / -I Mar 24, 2024
@sylvestre sylvestre force-pushed the replace branch 2 times, most recently from 5895040 to 0363266 Compare March 24, 2024 21:47
@sylvestre sylvestre changed the title xargs: Implement replace / -I xargs: Implement replace / -I (Closes: #310) Mar 25, 2024
cakebaker
cakebaker reviewed Mar 25, 2024
View reviewed changes
@sylvestre sylvestre requested a review from cakebaker March 26, 2024 08:37
cakebaker
cakebaker reviewed Mar 26, 2024
View reviewed changes
cakebaker
cakebaker reviewed Mar 27, 2024
View reviewed changes
cakebaker
cakebaker reviewed Mar 27, 2024
View reviewed changes
cakebaker
cakebaker reviewed Mar 27, 2024
View reviewed changes
cakebaker
cakebaker reviewed Mar 29, 2024
View reviewed changes
@sylvestre sylvestre requested a review from cakebaker March 31, 2024 15:42
cakebaker
cakebaker reviewed Apr 2, 2024
View reviewed changes
cakebaker
cakebaker reviewed Apr 2, 2024
View reviewed changes
cakebaker
cakebaker reviewed Apr 2, 2024
View reviewed changes
cakebaker
cakebaker reviewed Apr 2, 2024
View reviewed changes
sylvestre
sylvestre commented Apr 2, 2024
View reviewed changes
Copy link
Contributor Author

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we are good this time :)

@sylvestre sylvestre requested a review from cakebaker April 3, 2024 09:20
@cakebaker cakebaker merged commit 05d82ce into uutils:main Apr 3, 2024
@cakebaker
Copy link
Contributor

Good work :)

@sylvestre sylvestre deleted the replace branch April 3, 2024 12:51
@sylvestre
Copy link
Contributor Author

many thanks for this terrific review :)

@chenrui333 chenrui333 mentioned this pull request Apr 4, 2024
Merged
@YDX-2147483647 YDX-2147483647 mentioned this pull request Apr 25, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Jun 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

@cakebaker cakebaker Awaiting requested review from cakebaker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement -I / --replace

3 participants

@sylvestre @cakebaker @tertsdiepraam
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载