+
Skip to content

find: Fix -printf interactions with -L #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tavianator
Copy link
Contributor

  • %l should only trigger for broken symlinks

  • %Y should follow symlinks

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 64.86486% with 13 lines in your changes missing coverage. Please review.

Project coverage is 87.64%. Comparing base (e5f7dae) to head (3a680a4).

Files with missing lines Patch % Lines
src/find/matchers/printf.rs 64.28% 6 Missing and 4 partials ⚠️
src/find/matchers/mod.rs 66.66% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   87.69%   87.64%   -0.05%     
==========================================
  Files          31       31              
  Lines        6893     6906      +13     
  Branches      324      327       +3     
==========================================
+ Hits         6045     6053       +8     
- Misses        617      619       +2     
- Partials      231      234       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- %l should only trigger for broken symlinks

- %Y should follow symlinks
@sylvestre
Copy link
Contributor

could you please add high level tests to make sure we don't regress ?
thanks

@tavianator
Copy link
Contributor Author

There are bfs and probably GNU tests for this. Unfortunately I probably won't have time soon to add uutils test cases

@sylvestre
Copy link
Contributor

Sure but i still would to have tests in this repo, much easier for development
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载