+
Skip to content

Fix ring.response/attachment to handle space correctly #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2022
Merged

Fix ring.response/attachment to handle space correctly #19

merged 3 commits into from
May 18, 2022

Conversation

liquidz
Copy link
Contributor

@liquidz liquidz commented May 18, 2022

Currently toyokumo.commons.ring.response/attachment is encoding filename with url-encode only.
url-encode will replace spaces with +, so a file named hello world.txt will be downloaded as hello+world.txt.

This PR fix this problem.
I've confirmed the browser behavior by Chrome, Firefox, Edge and IE11.

@liquidz liquidz requested a review from makinoshi May 18, 2022 03:10
makinoshi
makinoshi approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@makinoshi makinoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liquidz
Copy link
Contributor Author

liquidz commented May 18, 2022

Thanks!

@liquidz liquidz merged commit 8cb603c into main May 18, 2022
@liquidz liquidz deleted the feature/filename-containing-spaces branch May 18, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makinoshi makinoshi makinoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liquidz @makinoshi
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载