refactor: use base64url instead hardcoded implementation and toString doc comment
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oString` doc comment Fixes ton-org#83
base64url instead hardcoded implementation and and toString doc commentbase64url instead hardcoded implementation and toString doc comment
| expect(address.toString({ bounceable: false, urlSafe: false })).toMatch('UQAs9VlT6S776tq3unJcP5Ogsj+ELLunLXuOb1EKcOQi41+E'); | ||
| expect(address.toString({ bounceable: false, urlSafe: false, testOnly: true })).toMatch('0QAs9VlT6S776tq3unJcP5Ogsj+ELLunLXuOb1EKcOQi4+QO'); | ||
| }); | ||
| it('should serialize with urlSafe=false', () => { |
There was a problem hiding this comment.
These match exactly 5 out of 8 expects from should serialize to friendly form test above. First of them considers urlSafe to be true. Is this intentional?
| /** | ||
| * Returns address as a string. | ||
| * | ||
| * @param args optional arguments with the following properties: |
There was a problem hiding this comment.
This doesn't provide documentation for completions/hovers of fields themselves, where it'd be more expected.
I'd suggest to put it directly into the type.
{
/**
* If true, returns url-friendly string, otherwise just base64
* @default true
*/
urlSafe?: boolean;
/**
* If true, returns bounceable address (with 0x11 tag), otherwise — non-bounceable (with 0x51 tag)
* @default true
*/
bounceable?: boolean;
/**
* If true, returns test-only address (with 0x80 tag), otherwise — non-test-only
* @default false
*/
testOnly?: boolean;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83