Fix broken windows #431
Merged
Fix broken windows #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes: - Remove `.prettierrc` and `eslint.config.js` - Add `biome.json` with formatting and linting rules - Update `package.json` to add `@biomejs/biome` and format arrays - Refactor imports to use `type` keyword where needed - Simplify conditional checks with optional chaining - Use arrow function for `error` event handler in `server.ts` - Update `readme.md` installation instructions
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR removes ioredis support, switches formatting and linting from Prettier/ESLint to Biome, and updates documentation and CI to match these changes.
- Drop ioredis compatibility code in
index.tsand remove related tests. - Introduce
biome.json, remove Prettier/ESLint configs, and update npm scripts. - Simplify README installation instructions and adjust CI workflow for Node 24.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/server.ts | Use type import for ChildProcess and convert error handler to an arrow function. |
| readme.md | Remove mentions of ioredis and update installation instructions to only require redis. |
| package.json | Update scripts to use Biome, remove ioredis and redis from devDependencies, adjust metadata. |
| index_test.ts | Remove ioredis test, switch from client.disconnect() to client.destroy(). |
| index.ts | Eliminate NormalizedRedisClient, rely on native redis types, rename helpers, add new scan logic. |
| eslint.config.js | Remove legacy ESLint configuration. |
| biome.json | Add Biome configuration for formatting and linting. |
| .prettierrc | Remove Prettier configuration. |
| .github/workflows/build.yml | Add Node 24 to CI matrix and drop the fmt-check step. |
Comments suppressed due to low confidence (2)
package.json:40
- The
redispackage was removed fromdevDependenciesand is now only a peerDependency; tests import fromredisand will fail without it. Consider re-addingredistodevDependenciesfor testing.
"express-session": "^1.18.1",
index_test.ts:2
- [nitpick] New code supports both standalone and clustered
RedisClientType, but there are no tests covering the cluster path. Consider adding a test against a Redis cluster instance to ensurescanIteratorandgetAllKeyswork as intended.
import { createClient } from "redis"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
ioredisredisv5 and laterreadme.mdinstallation instructionsRef: https://github.com/redis/node-redis
Ref: https://redis.io/docs/latest/develop/clients/nodejs/migration/