+
Skip to content

prs recipients add - feedback/bug #16

@colemickens

Description

@colemickens

Okay, in writing out this comment I looked a bit more and figured out what's going on.

Context:

  • I'm migrating from gopass
  • gopass seems to work "fine" for all normal operations I perform

Scenario:

  • I tried prs edit for the first time and it complained because I didn't have any recipients established

So I poked around a bit more, and then realized that something somewhat unexpected can happen -- my recipients and committed without me even realizing!

So, starting from a naive repo:

  • I ran prs edit, got a complaint about recipients
  • ran prs recipients ls -> no results
  • ran prs recipients add and then Ctrl+C'd out....
  • ran prs recipients ls -> ... shows a key... wait what?
  • ran git log and see that prs updated and committed my recipients for me, by:
    • deleted a maybe "wrong" duplicate of my gpg key in .public-keys
    • replaced the .gpg-id with the pubkey fingerprint instead of keygrip as I'd had in there (not sure if one is more valid than another, the manpage is vague)

(back-context - I think I'd basically added my gpg key TWICE to public-keys, once named by the keygrip, once named by the fingerprint).

So, I guess net result is probably fine. It seems that prs edit <foo> and gopass edit <foo> work fine now.

However, this was definitely a bit unexpected. Even just a log message of "recipients refreshed and committed" at the end of the process would've helped me realize that even though I Ctrl+C'd out of the selection dialog, that prs still went ahead and updated my recipients.

Thought I'd mention this - I don't know if there's a way to use this that would result in valid public keys being dropped... I don't necessarily know what else there is to do here, feel free to close as you see fit, but I thought I'd mention it, it definitely confused me.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载