setters - falsey values #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes, that slipped by me. Can you change the pull request to the dev branch though? I'm working on stuff for 1.1.0 and I want this to make it in. |
|
Sure! I'll just create a new pull request I suppose? I don't see a way to change it retroactively. |
butterflyhug
pushed a commit
to WhoopInc/frozen-moment-OLD
that referenced
this pull request
Jul 22, 2014
Fixed year lower bound from -270,00 to -270,000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using setters with falsey values (e.g.
0) the getter is called instead. This is fixed by a null comparison to use the setter for anything butnullandundefined.