+
Skip to content

Conversation

timerring
Copy link
Owner

Description

Adjust the position of the subtitles to avoid overlapping.

Related Issues

fix #102

Changes Proposed

  • Add the new parameter MarginV which aims to tune the bottom margin of the subtitles.
  • Revise the related functions.

Who Can Review?

@timerring

TODO

  • task1
  • ...

Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@timerring timerring added the enhancement New feature or request label Dec 7, 2024
@timerring timerring self-assigned this Dec 7, 2024
Copy link
Owner Author

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Wait for test.

Copy link
Owner Author

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@timerring timerring merged commit 0595a95 into main Dec 7, 2024
@timerring timerring deleted the dev branch December 7, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Fine-tune the position of subtitle

1 participant

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载