+
Skip to content

major rewrites to simplify new seasons #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 26, 2023

Conversation

khari05
Copy link
Contributor

@khari05 khari05 commented Nov 19, 2021

former title: update for 2021-2022

TODO:

- [x] fix building on android
- [x] finish the match breakdown
- [x] update localization
- [ ] maybe more descriptive member variable names for FreightFrenzyAllianceDetails?

I might get busy, here are my current changes.

New features:

Should be able to render match breakdowns using only i18n files and JSON schema

Dynamic dark theme w/ easy-dynamic-theme

TODO:

  • cleanup
  • add in the remaining seasons
  • add error catching for some of my precarious assumptions
  • Add back the unable to show data page

@khari05
Copy link
Contributor Author

khari05 commented Apr 16, 2022

Hey @ofekashery @theswerd, can you add HE and ES localization?

@nholo1332
Copy link
Contributor

I can add the Spanish translations. I'll try to get that done today

@khari05
Copy link
Contributor Author

khari05 commented Apr 16, 2022

I'm currently trying to get the app to build on Android since that is the last step before we can release this version

@ofekashery
Copy link
Member

Thank you so much, @khari05!

@nholo1332
Copy link
Contributor

Awesome, thanks! Once we're ready for this build to be released, I can push the iOS version to the AppStore.

@khari05 khari05 marked this pull request as ready for review April 16, 2022 19:10
@khari05 khari05 changed the title [WIP] update for 2021-2022 update for 2021-2022 Apr 16, 2022
khari05 added 2 commits June 23, 2023 02:03
THEORETICALLY we no longer have to write new code every season!
TODO: ADD ERROR CHECKING; im sleepy
@khari05 khari05 changed the title update for 2021-2022 major rewrites to simplify new seasons Jun 23, 2023
@khari05
Copy link
Contributor Author

khari05 commented Jun 23, 2023

I'm really happy with how straightforward it was to overhaul the most tedious part of updating the app

Only needed like 3 pages of infrastructure diagrams

by parallelizing the API requests so they complete asynchronously
fixed a small error w/ skystone matches containing some null value
@khari05
Copy link
Contributor Author

khari05 commented Jun 23, 2023

In my rough testing, this previous commit makes the team info page open in half the time. Here are some numbers I collected from Dart DevTools:

first request made last request finishes total time average
17:29:21.878 17:29:30.791 9.03 seconds
17:35:57.557 17:36:06.513 8.956 seconds 8.993 seconds
17:39:49.243 17:39:53.116 3.873 seconds
17:46:59.292 17:47:03.080 3.788 seconds 3.8305 seconds

@khari05
Copy link
Contributor Author

khari05 commented Jun 24, 2023

Hey @ofekashery can you take a look at this?

Copy link
Member

@ofekashery ofekashery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @khari05! That's amazing.

@khari05
Copy link
Contributor Author

khari05 commented Jun 26, 2023

Using a bit of json schema and helper functions greatly reduces the code we need to write. I think it took me ≈3 hours to add in this past season.
image

@khari05 khari05 requested a review from ofekashery June 26, 2023 07:25
@ofekashery
Copy link
Member

Thank you so much @khari05 ❤️

@ofekashery ofekashery merged commit ae9dd28 into the-orange-alliance:dev Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载