-
Notifications
You must be signed in to change notification settings - Fork 4
major rewrites to simplify new seasons #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
has some issue with android embedding v2 and firebase messaging
Hey @ofekashery @theswerd, can you add HE and ES localization? |
I can add the Spanish translations. I'll try to get that done today |
I'm currently trying to get the app to build on Android since that is the last step before we can release this version |
Thank you so much, @khari05! |
Awesome, thanks! Once we're ready for this build to be released, I can push the iOS version to the AppStore. |
THEORETICALLY we no longer have to write new code every season! TODO: ADD ERROR CHECKING; im sleepy
I'm really happy with how straightforward it was to overhaul the most tedious part of updating the app
|
by parallelizing the API requests so they complete asynchronously fixed a small error w/ skystone matches containing some null value
In my rough testing, this previous commit makes the team info page open in half the time. Here are some numbers I collected from Dart DevTools:
|
Hey @ofekashery can you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @khari05! That's amazing.
it took barely an hour to add in support for 2223
Thank you so much @khari05 ❤️ |
former title: update for 2021-2022TODO:- [x] fix building on android- [x] finish the match breakdown- [x] update localization- [ ] maybe more descriptive member variable names for FreightFrenzyAllianceDetails?I might get busy, here are my current changes.New features:
Should be able to render match breakdowns using only i18n files and JSON schema
Dynamic dark theme w/ easy-dynamic-theme
TODO: