New MenuBar Features: Submenus, disable individual items, any ReactNode as display value #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add demo video please? |
Done |
AyIong
reviewed
Sep 11, 2025
Handled |
AyIong
approved these changes
Sep 12, 2025
jlsnow301
reviewed
Sep 12, 2025
ZeWaka
reviewed
Sep 13, 2025
Yes... perhaps it is not necessary to rename props unless absolutely necessary |
ZeWaka
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This PR adds several features to the MenuBar - two to add functionality that native window menus usually have, and one that feels appropriate given the way the property is used.
displayTextproperty now accepts any ReactNode. It has not been renamed to reflect this because it would be a breaking change.Video demonstration
2025-09-11.18-18-39.mp4
Why's this needed?
There's a ui I wanted to code for tg and the main additions from this PR were something I felt were needed to get the look and feel I wanted. Other people who want to make changes to stuff like modular computer applications would probably also appreciate these changes.