Adds onWheel to BoxProps #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyIong
requested changes
Sep 10, 2025
AyIong
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This adds onWheel to the list of event handlers that can be included as a Box prop. While it's not supported on Safari or iOS WebView, I doubt anyone using tgui-core is going to use either of those user agents.
Why's this needed?
Among other things, this enables mouse-wheel zooming on individual elements without the use of the native zoom event, which is something I feel would be nice for certain UIs, particularly those I'm developing for a feature on the main tg codebase.
I had commented that I was too lazy to directly add onWheel to BoxProps, but there's something else I wanted to do with the UI that would also require a tgui-core PR, so I decided if I'm going to have to make that change, I have no excuse not to make this one.