Fixes for scrollable Tabs #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixed slightly incorrect styles, which caused Tabs to stretch the container it was in and ruin the entire layout.
Also adjusted mask-image so that it scales from the text size and looks more obvious.
During testing in real conditions, I was discovered that when UI is autoupdating (once every 1-2 seconds), it scrolls to the selected tab occurred due to the children dependency. This should no longer occur, and nothing should interfere tabs scrolling.
dreamseeker_8W5DzmtOb2.mp4
Why's this needed?
Fixing shit... Storybook never can replace testing on prod