+
Skip to content
This repository was archived by the owner on Jun 18, 2025. It is now read-only.

Conversation

sritchie
Copy link
Member

@sritchie sritchie commented Nov 16, 2021

From the CHANGELOG:

  • Add define-coordinates implementation #393:

    • Forms like (let-coordinates [(up x y) R2-rect] ...) will now work even if
      up is not present in the environment. Previously this syntax was valid,
      but only if up had been imported.

    • Adds the sicmutils.calculus.coordinate/define-coordinates macro, also
      aliased into sicmutils.env. This macro allows you to write forms like

(define-coordinates (up t x y z) spacetime-rect)
(define-coordinates [r theta] R2-polar)

and install set of bindings for a manifold's coordinate functions, basis
vector fields and basis form fields into a namespace. This is used liberally
in Functional Differential Geometry. (You might still prefer let-coordinates
for temporary binding installation.)

  • Converts many of the sicmutils.fdg test namespaces to use the new
    define-coordinates macro, making for a presentation closer to the book's.

  • Fixes a Clojurescript warning in sicmutils.util warning due to
    redefinition of clojure.core/uuid

@sritchie sritchie force-pushed the sritchie/def_coords branch from f79d86d to facf1a9 Compare November 17, 2021 13:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

Merging #393 (3c19bf1) into master (4887864) will increase coverage by 0.02%.
The diff coverage is 84.28%.

❗ Current head 3c19bf1 differs from pull request most recent head 1e92ea9. Consider uploading reports for the commit 1e92ea9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   85.19%   85.22%   +0.02%     
==========================================
  Files          97       97              
  Lines       12936    12996      +60     
  Branches      695      696       +1     
==========================================
+ Hits        11021    11076      +55     
- Misses       1220     1224       +4     
- Partials      695      696       +1     
Impacted Files Coverage Δ
src/sicmutils/util.cljc 88.33% <ø> (ø)
src/sicmutils/util/def.cljc 68.65% <52.63%> (-2.78%) ⬇️
src/sicmutils/calculus/coordinate.cljc 89.23% <92.30%> (+3.18%) ⬆️
src/sicmutils/env.cljc 93.33% <100.00%> (+0.15%) ⬆️
src/sicmutils/env/sci/macros.cljc 84.04% <100.00%> (+3.77%) ⬆️
src/sicmutils/function.cljc 93.54% <100.00%> (ø)
src/sicmutils/generic.cljc 79.42% <0.00%> (+0.36%) ⬆️
src/sicmutils/numsymb.cljc 92.96% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4887864...1e92ea9. Read the comment docs.

@sritchie sritchie force-pushed the sritchie/def_coords branch from 3c19bf1 to 1e92ea9 Compare November 18, 2021 17:28
@sritchie sritchie merged commit 8658c0c into master Nov 18, 2021
@sritchie sritchie deleted the sritchie/def_coords branch November 18, 2021 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add define-coordinates, install-coordinates, uninstall-coordinates from FDG

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载