This repository was archived by the owner on Jun 18, 2025. It is now read-only.
fix advanced compilation issues with Fraction #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2021 07:12
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
- Coverage 84.22% 84.09% -0.14%
==========================================
Files 97 97
Lines 12858 12874 +16
Branches 675 687 +12
==========================================
- Hits 10830 10826 -4
- Misses 1353 1361 +8
- Partials 675 687 +12
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the CHANGELOG:
fix advanced compilation issues with Fraction #371:
fixes a subtle bug with extern inference on
fraction.js/bigfraction.js.Thanks to @sigmaxipi for this report!
removes overridden factory constructors like
->Polynomial. I hadoriginally done this for functions that held a metadata field, so that the
user could leave it out and have it default to
nil... but advanced Closurecompilation can't understand the
ns-unmapcall, so it has to go.Many unary functions on
Operator,Structure,Series,PowerSeries,PolynomialandRationalFunctionnow preserve metadata. Binary functionsbetween two instances of any of these still return a new object with
metadata ==
nil.