feat(select/AlertDialog): add support for long option names with truncation in Select and AlertDialog #8395
+63
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2025 10:42
…yout. Updated styles to prevent text overflow in titles and descriptions across multiple instances.
|
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
@shadcn Please review the PR and share any feedback or suggested changes. |
|
@Alantitus I'll review. IIRC there was a specific reason I did not add the truncate in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8355
Problem
SelectValue with long label exceed width of dialog
Affected component/components
AlertDialog, Select
Fix Added
I added the truncate class to the SelectValue styling in all three select component implementations:
The fix ensures that when a SelectValue contains long text:
AlertDialogTitle: Added break-words class to handle long titles that could exceed dialog width
AlertDialogDescription: Added break-words class to handle long descriptions that could exceed dialog width