[2]feat(2695): Does not overwrite PR comment that from other PR job #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
reviewed
Jun 9, 2022
index.js
Outdated
| const botComment = prComments.comments.find( | ||
| commentObj => | ||
| commentObj.user.login === this.config.username && | ||
| commentObj.body.split(/\n/)[0].match(/^.+pipelines\/(\d+)\/builds.+ ([\w-:]+)$/) && |
There was a problem hiding this comment.
might be easier to read if it's saved as a variable
but not blocking
There was a problem hiding this comment.
I stored the regular expression in a global variable.
tkyi
approved these changes
Jun 9, 2022
kumada626
approved these changes
Jun 10, 2022
ibu1224
approved these changes
Jun 10, 2022
|
🎉 This PR is included in version 11.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If multiple jobs have PR comments, the later job's comment overwrites the earlier job's comment.
Objective
We change so that PR comments are only edited by the same job in the same pipeline.
References
https://docs.github.com/ja/rest/issues/comments#list-issue-comments
screwdriver-cd/screwdriver#2695
Reflect the following PRs before reflecting this.
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.