Make sealed trait/enum matching order deterministic #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateuszKubuszok
requested changes
May 24, 2024
.../scala-2/io/scalaland/chimney/internal/compiletime/datatypes/SealedHierarchiesPlatform.scala
Outdated
Show resolved
Hide resolved
.../scala-3/io/scalaland/chimney/internal/compiletime/datatypes/SealedHierarchiesPlatform.scala
Show resolved
Hide resolved
|
Thanks again for the fix! 🙏 Since we already updated Scala 2.13 stdlib to 2.13.14 (which slightly changes the contracts) I'd like the next release to be 1.1.0, and I would also like to merge Scala Native 0.5.1 support with it, which is currently blocked. Once I'll be able to merge it, I'll publish your changes as part of 1.1.0. |
|
Released as 1.1.0 |
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classfiles of generated transformers are slightly different, the order of sealed subclasses is non-deterministic.
We're using bazel as a build tool and it's important for build to produce an exact same file for the same input, otherwise it's dependent targets are re-evaluated.