Fix: Handle empty queries in TavilySearchRM to prevent "Query is missing" error (#362) #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing' error - Add input validation for empty, None, and whitespace-only queries - Filter out invalid queries from lists while keeping valid ones - Add error handling around Tavily API calls - Return empty results gracefully instead of crashing - Add informative warning messages for debugging Fixes stanford-oval#362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #362 - "Query is missing" error when using TavilySearchRM with MCP servers
This PR adds comprehensive input validation to
TavilySearchRM.forward()to handle empty, None, or invalid queries gracefully.Problem
Users reported getting "Query is missing" errors when integrating STORM with MCP (Model Context Protocol) servers. The error occurred when empty or None queries were passed to the Tavily search API.
Solution
Changes Made
knowledge_storm/rm.pyinTavilySearchRM.forward()methodtavily_client.search(query)Testing
The fix correctly handles:
"")" ")[])Backward Compatibility
✅ This change is fully backward compatible - all existing valid use cases continue to work exactly as before.
Type of Change