You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 31, 2023. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new !bench_cli command similar to the existing !bench_* comments we can use to trigger benchmark runs of the analyzer, formatter and parser on pull requests. The CLI is special though as it's using hyperfine to run the actual CLI binary on the same repos used for the benchmark suite in benchmark/ (Webpack, Prettier and ESLint), as opposed to using criterion to benchmark individual parts of the toolchain.
Test Plan
Unfortunately I don't think I can run this workflow without merging it first, hopefully it shouldn't take too many tries to get it to work correctly ...
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new
!bench_clicommand similar to the existing!bench_*comments we can use to trigger benchmark runs of the analyzer, formatter and parser on pull requests. The CLI is special though as it's usinghyperfineto run the actual CLI binary on the same repos used for the benchmark suite inbenchmark/(Webpack, Prettier and ESLint), as opposed to usingcriterionto benchmark individual parts of the toolchain.Test Plan
Unfortunately I don't think I can run this workflow without merging it first, hopefully it shouldn't take too many tries to get it to work correctly ...