+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

chore(VSCode): publish extension to Open VSX #3677

Merged
merged 2 commits into from
Nov 16, 2022
Merged

chore(VSCode): publish extension to Open VSX #3677

merged 2 commits into from
Nov 16, 2022

Conversation

sebmck
Copy link
Contributor

@sebmck sebmck commented Nov 11, 2022

Summary

Adds publishing to Open VSX to our release actions.

Test Plan

Not sure? cc @ematipico @leops for how I might test this. If the changes look okay then we can wait for the next release before publishing our first version.

@sebmck sebmck requested a review from a team November 11, 2022 20:48
@netlify
Copy link

netlify bot commented Nov 11, 2022 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit f9ecf28
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63701edd266ea300085954e8

@sebmck sebmck mentioned this pull request Nov 11, 2022
Closed
@MichaReiser MichaReiser linked an issue Nov 12, 2022 that may be closed by this pull request
📎 Publish Rome to Open VSX #3676
Closed
MichaReiser
MichaReiser reviewed Nov 12, 2022
View reviewed changes
@sebmck
Copy link
Contributor Author

sebmck commented Nov 12, 2022

Fixed binary reference. I've also added the Open VSX PAT token to the marketplace environment so this should just work.

@ematipico ematipico changed the title [lsp] Publish extension to Open VSX chore(VSCode): publish extension to Open VSX Nov 13, 2022
@MichaReiser
Copy link
Contributor

Looks good. Can you manually trigger an LSP workflow and then approve it to publish a nightly release to the marketplace?

https://github.com/rome/tools/actions/workflows/release_lsp.yml

@MichaReiser MichaReiser added this to the 11.0.0 milestone Nov 14, 2022
@MichaReiser MichaReiser added the A-Editors Area: editors label Nov 14, 2022
MichaReiser
MichaReiser suggested changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test plan with a run of the LSP action.

@ematipico
Copy link
Contributor

ematipico commented Nov 14, 2022 •
edited
Loading

What's the plan to document this? I assume this needs to be documented somewhere on our website

@MichaReiser
Copy link
Contributor

What's the plan to document this? I assume this needs to be documented somewhere on our website

We should mention it in the VS Code section

@ematipico
Copy link
Contributor

What's the plan to document this? I assume this needs to be documented somewhere on our website

We should mention it in the VS Code section

Sorry, I actually meant the real plan. There wasn't any issue to track documentation changes, so I wanted to know where/how we take note of this new change.

@MichaReiser MichaReiser temporarily deployed to marketplace November 16, 2022 09:03 Inactive
@MichaReiser
Copy link
Contributor

MichaReiser commented Nov 16, 2022 •
edited
Loading

Test plan:

@MichaReiser MichaReiser merged commit 1837140 into main Nov 16, 2022
@MichaReiser MichaReiser deleted the sebmck/ovsx branch November 16, 2022 09:14
@MichaReiser MichaReiser mentioned this pull request Nov 16, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees

@sebmck sebmck

Labels
A-Editors Area: editors
Projects
Rome 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 Publish Rome to Open VSX
3 participants
@sebmck @MichaReiser @ematipico
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载