This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_cli): print number of errors in summary #3651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for docs-rometools failed.Built without sensitive environment variables
|
MichaReiser
reviewed
Nov 11, 2022
|
somehow the snapshot tests are failing after updating them, any idea how i can fix it? |
MichaReiser
approved these changes
Nov 14, 2022
We use |
ematipico
reviewed
Nov 14, 2022
crates/rome_cli/tests/snapshots/main_commands_check/apply_noop.snap
Outdated
Show resolved
Hide resolved
MichaReiser
approved these changes
Nov 14, 2022
ematipico
approved these changes
Nov 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prints the number of errors emitted on the
checksummary, or at least tries to. I'm not really experienced in Rust so it's very possible this breaks something / doesn't work as intended, but it does its job, I guess. Feel free to supersede or suggest changes if you have a better approachCloses #3588
Test Plan
Commands ran:
where
my-cool-ts-projectis a directory with a TypeScript file