This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_analyze): extend ActionCategory to allow expressing more code action kinds #3627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
…g more code action categories
9f4ef6b to
efc1a9d
Compare
ematipico
reviewed
Nov 14, 2022
|
@leops would it be possible to have a code action specifically for rule suppression via editors? Having a category for them would make things way easier on the long run. |
This is what the |
ematipico
approved these changes
Nov 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds new variants and sub-enums to the
ActionCategoryenum inrome_analyzeto allow creating code actions with other "root kinds" thanquickfixandrefactor(such assource), as well as express sub-types for refactor and source actions (such asextract,inlineandrewritefor refactors).In addition to this, code action kinds are now suffixed with
.rome.<rule group>.<rule name>: this allows user to specify they want the "Fix All" action exposed by Rome instead of any fix-all action to be applied automatically on save using"editor.codeActionsOnSave": { "source.fixAll.rome": true }, or to explicitly request that code actions emitted by a given rule are applied automatically (again by adding entries such asquickfix.rome.correctness.useWhiletocodeActionsOnSave)Test Plan
I've extended the test cases for pulling diagnostics, quickfixes and refactors from the LSP and added a new test for pulling the "fix all" action.