This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): make empty line after hashbang optional #3552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
unvalley
commented
Nov 2, 2022
Comment on lines
127
to
131
| if interpreter.kind() == JsSyntaxKind::JS_SHEBANG { | ||
| write!(f, [interpreter.format(), hard_line_break()]) | ||
| } else { | ||
| write!(f, [interpreter.format(), empty_line()]) | ||
| } |
There was a problem hiding this comment.
Honestly speaking, I don't have confidence that the changes here are reasonable.
This file is under the utils/, Is JS_SHEBANG allowed to appear here?
Please let me know, if this change is not correct direction.
MichaReiser
reviewed
Nov 2, 2022
unvalley
commented
Nov 3, 2022
MichaReiser
reviewed
Nov 3, 2022
MichaReiser
approved these changes
Nov 3, 2022
|
I've learned a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3497
Test Plan
I updated snapshot results by
cargo insta review.