This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_parser): call expression in optional member chain followed by <
#3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by `<` This PR fixes a false diagnostic for call expressions that are part of an optional chain (static member) that are then followed by a binary `<` expression. ``` String(item)?.b <aBcd; ``` The problem is that the error recovery code for `a.test?.` incorrectly kicked in which should not happen if what followed after the call expression is a valid static member expression in an optional chain. fixes #3486
✅ Deploy Preview for rometools canceled.
|
MichaReiser
commented
Oct 26, 2022
| // * if the parser is at '(': This always parses out as valid arguments. | ||
| debug_assert_eq!(p.tokens.position(), start_pos); | ||
| m.abandon(p); | ||
| break if optional_chain_call { |
There was a problem hiding this comment.
The main fix is to test for optional_chain_call instead of in_optional_chain. The former is only true for a()?. but the latter can also be true for a()?.b (which has already been handled by the member expression parsing
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
ematipico
approved these changes
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a false diagnostic for call expressions that are part of an optional chain (static member) that are then followed by a binary
<expression.The problem is that the error recovery code for
a.test?.incorrectly kicked in which should not happen if what followed after the call expression is a valid static member expression in an optional chain.fixes #3486