This repository was archived by the owner on Aug 31, 2023. It is now read-only.
refactor: use new diagnostics #3439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
|
Comparing refactor: use new diagnostics Snapshot #19 to median since last deploy of rome.tools.
1 page tested
|
| Chrome Desktop | iPhone, 4G LTE | Motorola Moto G Power, 3G connection |
|---|---|---|
 |
 |
 |
Most significant changes
 |
Value | Budget |
|---|---|---|
| Total JavaScript Size in Bytes Chrome Desktop |
1.23 MB  from 86.8 KB |
 |
| Total JavaScript Size in Bytes iPhone, 4G LTE |
1.23 MB from 86.8 KB |
|
| Total JavaScript Size in Bytes Motorola Moto G Power, 3G connection |
1.23 MB from 86.8 KB |
|
| Cumulative Layout Shift Chrome Desktop |
0.049  from 0.006 |
|
| Number of Requests iPhone, 4G LTE |
39  from 5 |
|
6 other significant changes: Number of Requests on Chrome Desktop, Number of Requests on Motorola Moto G Power, 3G connection, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, Time to Interactive on Chrome Desktop
Calibre: Site dashboard | View this PR | Edit settings | View documentation
6db028f to
27d8138
Compare
27d8138 to
6c66308
Compare
a78c61c to
a801ed4
Compare
9e932ac to
64ad44d
Compare
64ad44d to
d730f6e
Compare
d730f6e to
e724a62
Compare
458dd69 to
1de916e
Compare
leops
approved these changes
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves to the use of the new diagnostics inside the parser and analyzer. Previous PRs have been approved and merged here to make the transition smooth and less painful.
Test Plan
The CI should pass.