+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

docs(website): small QoL for rules page #3407

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Oct 12, 2022

Summary

Small chore for the website:

  • better wording for the Nursery group
  • added anchor link for titles of the rules
  • finally added the version at the footer of the website
  • updated an outdated section of the website

Test Plan

Check the deployed website

@ematipico ematipico requested a review from a team October 12, 2022 10:20
@netlify
Copy link

netlify bot commented Oct 12, 2022

Deploy Preview for rometools ready!

Name Link
🔨 Latest commit b76f7fb
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/63469989eb929b0007cd19da
😎 Deploy Preview https://deploy-preview-3407--rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44939 44939 0
Failed 940 940 0
Panics 0 0 0
Coverage 97.95% 97.95% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1621 1621 0
Failed 4325 4325 0
Panics 0 0 0
Coverage 27.26% 27.26% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12395 12395 0
Failed 3862 3862 0
Panics 0 0 0
Coverage 76.24% 76.24% 0.00%

@@ -208,7 +209,10 @@ module.exports = function (eleventyConfig) {
});

eleventyConfig.addShortcode("romeVersion", function () {
return "?.?.?";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@ematipico ematipico merged commit 4058d53 into main Oct 12, 2022
@ematipico ematipico deleted the website/more-documentation branch October 12, 2022 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载