+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

refactor: move js bindings to a scoped package #3323

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Oct 4, 2022

Summary

This PR moves the TypeScript code we had under the folder npm/rome inside a new folder called js-api. The new package is called @rometools/js-api. Any suggestions for a better name?

As agreed, we want to make the JS APIs an opt-in feature only for people that really wants to use Rome via JS. This will make the main package rome really slim.

What's done:

  • update the github workflows
  • moved scripts and packages under the new folder
  • created a non-final README.md file

What I will do in a different PR:

  • implement the final touches for the README.md
  • implement the workflow for publishing the package automatically (and maybe the nightly build too)

Test Plan

The existing CI should work and pass

@ematipico ematipico requested a review from a team October 4, 2022 15:40
@netlify
Copy link

netlify bot commented Oct 4, 2022

Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit 2b15307
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/633c56f5a8375c000a491cf7

@ematipico ematipico added the A-Runtime Work around runtime label Oct 4, 2022
@ematipico ematipico force-pushed the refactor/move-api-to-new-package branch from df5d38a to 2b15307 Compare October 4, 2022 15:53
@ematipico ematipico merged commit 7a501c5 into main Oct 5, 2022
@ematipico ematipico deleted the refactor/move-api-to-new-package branch October 5, 2022 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Runtime Work around runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载