This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_formatter): Best fitting start entry #3310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this when investigating how to correctly implement `fill`. The problem with only pushing the items of the variant after the `StartEntry` is that any `QueuePredicate` that counts the start/end entries won't see the corresponding `StartEntry`. Manually pushing the `StartEntry` onto the stack isn't even necessary because it uses the same `args` anyway
✅ Deploy Preview for rometools canceled.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when investigating how to correctly implement
fill.The problem with only pushing the items of the variant after the
StartEntryis that anyFitsPredicatethat counts the start/end entries won't see the correspondingStartEntry.Manually pushing the
StartEntryonto the stack isn't even necessary because it uses the sameargsanywayWhy is it important to be fixed. A
FitsPredicatemay return aPrintError::InvalidDocumentif it believes that it has seen anEndEntrywithout a matchingStartEntryeven for valid documents.