Is it possible to have all combinations of children_cause, dangerous_prop_case, children_prop, and crate_react_element` or can we limit the possible combinations and represent them as a union?

I'm asking because limiting the possibilities can help readers to understand what combinations can exist and using an enum to name them makes them into explicit concepts (that can even be documented). It may also help to avoid some unreachable branches in the code.

It really depends on how we want the rule to work. My initial implementation was using an enum, but then I noticed that the old rule works by tracking all the invalid cases.

In this rule, we could have up to three errors at once:

React.createElement('img', {
	children: 'child', // <= diagnostic triggered
	dangerouslySetInnerHTML: 'html' // <= diagnostic triggered
}, 'child') // <= diagnostic triggered for 'child'

The upside of using an enum state would make the rule simple to understand for us, on the other hand this would generate up to three diagnostics that will show up to three code actions - basically we shift the burden to the user.

Tracking all the states at once allows us to emit one single code action and one single diagnostics.

Eventually ALL the suggested fixes are applied and the resultant code will be the same in both cases.

I don't mind both approaches, but I am more keen to use the single diagnostic approach.