This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_formatter): Panic for out of order group id #3236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
Use `TextSize` instead of usize to represent text positions in the printer. This PR also fixes an issue where the printer panics if group ids aren't written to the document in the same order as they have been created because `resize` shrinks a vector if its size exceeds the argument.
fa49c78 to
afddd1b
Compare
TextSize in printer
ematipico
approved these changes
Sep 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the printer panics if group ids aren't written to the document in the same order as they have been created because
resizeshrinks a vector if its size exceeds the argument.Test Plan
I added a new printer test verifying that the printer no longer panics if group ids aren't added in the same order as they have been created with
f.group_id.