This repository was archived by the owner on Aug 31, 2023. It is now read-only.
perf(rome_rowan): SyntaxNodeText improvements
#3217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves the performance of `SyntaxNodeText` by using the `token_at_offset` method rather than traversing over all tokens in the tree until it find the first token that has an overlapping range. Using `token_at_offset` has better performance because it only traverses into nodes that have an overlapping range. Example: Getting the text for `+ e` in ``a + b + c + d + e` * Old implementation: Traverses through the whole tree until it reaches the `+` token * New: Finds the `+` on the first level, then traverses into `e` Doing this improvement I discovered that `noShoutyConstants` uses `SyntaxNodeText` over `SyntaxTokenText`. `SyntaxTokenText` has the better performance because it isn't necessary to find the first token with an overlapping range. So, I refactored the implementation to use `SyntaxTokenText` instead ## Performance ``` group main text ----- ---- ---- analyzer/css.js 1.06 1238.1±109.59µs 9.4 MB/sec 1.00 1167.7±6.84µs 9.9 MB/sec analyzer/index.js 1.03 3.6±0.36ms 9.2 MB/sec 1.00 3.5±0.30ms 9.4 MB/sec analyzer/lint.ts 1.04 2.1±0.07ms 19.6 MB/sec 1.00 2.0±0.01ms 20.4 MB/sec analyzer/parser.ts 1.05 4.3±0.35ms 11.4 MB/sec 1.00 4.1±0.17ms 12.0 MB/sec analyzer/router.ts 1.00 2.8±0.14ms 21.9 MB/sec 1.02 2.9±0.02ms 21.5 MB/sec analyzer/statement.ts 1.00 3.8±0.17ms 9.3 MB/sec 1.01 3.8±0.12ms 9.3 MB/sec analyzer/typescript.ts 1.22 7.4±1.25ms 7.3 MB/sec 1.00 6.1±0.46ms 9.0 MB/sec ```
✅ Deploy Preview for rometools canceled.
|
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
leops
approved these changes
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of
SyntaxNodeTextby using thetoken_at_offsetmethod rather than traversing over all tokens in the tree until it find the first token that has an overlapping range. Usingtoken_at_offsethas better performance because it only traverses into nodes that have an overlapping range.Example: Getting the text for
+ ein ``a + b + c + d + e`+token+on the first level, then traverses intoeDoing this improvement I discovered that
noShoutyConstantsusesSyntaxNodeTextoverSyntaxTokenText.SyntaxTokenTexthas the better performance because it isn't necessary to find the first token with an overlapping range. So, I refactored the implementation to useSyntaxTokenTextinsteadPerformance
Test Plan
I added new doc tests and integration tests for the changes in
rome_rowanandrome_text_size