This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_text_size): fork crate #3114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
7047aae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2313dbf3.tools-8rn.pages.dev |
| Branch Preview URL: | https://feature-rome-text-size.tools-8rn.pages.dev |
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
MichaReiser
approved these changes
Aug 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new crate called
rome_text_size, which is a fork of https://github.com/rust-analyzer/text-sizeThe need of having our own fork is rising, because there were times where us developers needed to create new functions. Also, we run into some trouble with its serialization/deserialization.
Having it inside our workspace would allow us to extend it and change at our will.
I copied tests, source code and licenses.
This is something that all of us agreed to have, sooner rather than later.
Test Plan
This is mostly a compile time test, there's no change in logic. The CI should pass.