+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

chore(playground): allow vite to reference npm directory #3106

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

bhbs
Copy link
Contributor

@bhbs bhbs commented Aug 24, 2022

Summary

Playground's development environment is broken.
Fixed vite.config.ts

Details

Error: The request url "/Users/bhbs/Documents/GitHub/tools/npm/wasm-web/rome_wasm_bg.wasm" is outside of Vite serving allow list.

error

Full text
> playground@0.0.0 start /Users/bhbs/Documents/GitHub/tools/website/playground
> vite


  vite v2.9.5 dev server running at:

  > Local: http://localhost:3000/
  > Network: use `--host` to expose

  ready in 120ms.

Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
The request url "/Users/bhbs/Documents/GitHub/tools/npm/wasm-web/rome_wasm_bg.wasm" is outside of Vite serving allow list.

- /Users/bhbs/Documents/GitHub/tools/website/playground

Refer to docs https://vitejs.dev/config/#server-fs-allow for configurations and more details.

Test Plan

Exec Installation step
https://github.com/rome/tools/blob/main/website/playground/README.md

cd website/playground
pnpm build:wasm
pnpm install
pnpm start

@bhbs bhbs requested a review from a team August 24, 2022 14:04
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I understand now what's this line fixes :)

Thank you very much!

@ematipico ematipico merged commit 565df0f into rome:main Aug 24, 2022
@bhbs bhbs deleted the fix/vite-config-dev branch August 28, 2022 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载