This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(npm): hook *Conent APIs to WASM bindings
#3097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
9a7ec82
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4adc94da.tools-8rn.pages.dev |
| Branch Preview URL: | https://feature-api-integration.tools-8rn.pages.dev |
ematipico
commented
Aug 23, 2022
MichaReiser
reviewed
Aug 23, 2022
MichaReiser
reviewed
Aug 24, 2022
MichaReiser
approved these changes
Aug 24, 2022
6b637bf to
9a7ec82
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #3073
In this PR the Node.js API are hooked to the WASM bindings.
This PR only focuses on hooking the
*ContentAPIs. The file system APIs are left out on purpose. For the being also custom configuration left out on purpose, and will be implemented as part of a different PR.Things that are relevant for the review:
Workspaceof the WASM bindings are synchronous, but there were made asynchronous ( withawait) because it would allow us to easily swap backend in the future without too many problems.@rometools/backend-jsonrpctoes2020because we don't need to support old syntax. This has also the benefit that the emitted code is easier to debug@ts-expect-error. Once fixed, we can remove the suppressionTest Plan
I updated the tests we had with real expected output