ci: run ci using the version on main
#3076
Conversation
Deploying with
|
| Latest commit: |
560a0de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f976348.tools-8rn.pages.dev |
| Branch Preview URL: | https://chore-ci-with-current-rome.tools-8rn.pages.dev |
There was a problem hiding this comment.
Currently there's a test-cli job in the pull_request workflow that does more or less the same thing (build and run the CLI on the editors and website directories) but is marked as continue-on-error, I guess it can be removed now.
Also we should probably change the trigger for the pull_request_js workflow now to include the Rust codebase as well, to ensure the JS code doesn't go out of sync again when we change the analyzer or formatter (unfortunately it makes the Rust / JS workflow separation somewhat meaningless)
Are you up to merge |
I don't think I would completely merge the existing workflows, I think we could still have 3 |
OK, another PR for that :) better to not lose focus. Cheers |
Summary
This PR replace the usage of
setup-rome, with the usage of the current version we have onmain.The main reason for changing this, is that we don't have enough occasions to dogfooding rome, and this change will help use doing so. Now we are starting to have a bunch JS code that we can use as guinea big.
While doing so, I found a bunch of false positives. There's also some cases that we haven't considered:
In this snippet
resis not used, and the suggested fix asks to removeres. Not sure if we should ignore the case or leave it as is.Test Plan
The CI should pass