This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_formatter): Dedent to Root IR #3062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8528e11 to
94256b1
Compare
Deploying with
|
| Latest commit: |
8e9381d
|
| Status: | ⚡️ Build in progress... |
This PR extends the `dedent` IR element to support dedenting by one level or to the start of the line. I intentionally called the mode `root` because it may become necessary in the future that it's possible to mark a root which is different to the start of the line. This IR is necessary to correctly format `TemplateLiteral`s where inserting any indent characters that weren't present of the template in the source changes the `template`s content at runtime.
94256b1 to
86919fa
Compare
ematipico
approved these changes
Aug 15, 2022
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the
dedentIR element to support dedenting by one level or to the start of the line.I intentionally called the mode
rootbecause it may become necessary in the future that it's possible to mark a root which is different to the start of the line.This IR is necessary to correctly format
TemplateLiterals where inserting any indent characters that weren't present of the template in the source changes thetemplates content at runtime.Test Plan
I added a doc test demonstrating how the IR can be used and verifies that the printer correctly resets the indent level.