+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

fix(playground): 🐛 fix rome ast grammar error #3032

Merged
merged 2 commits into from
Aug 9, 2022
Merged

fix(playground): 🐛 fix rome ast grammar error #3032

merged 2 commits into from
Aug 9, 2022

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Aug 9, 2022 •
edited
Loading

Summary

  1. FIx serval grammar cases see video below:
    for such piece of code
class test {
  declare readonly test = 1;
}

before:

before.mp4

after:

after.mp4
  1. Adding a new temporary rome.json to workaround the false positive noUnusedVariable rule.

Test Plan

  1. See my preview video or testing locally

@IWANABETHATGUY IWANABETHATGUY requested a review from a team August 9, 2022 05:45
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Aug 9, 2022
Closed
@IWANABETHATGUY
Copy link
Contributor Author

For grammar change summar see:

  1. https://github.com/IWANABETHATGUY/lang-rome-ast/pull/3/files
  2. Fix/recursive syntax node IWANABETHATGUY/lang-rome-ast#4

@IWANABETHATGUY IWANABETHATGUY changed the title fix: 🐛 fix rome ast grammar error fix(playground): 🐛 fix rome ast grammar error Aug 9, 2022
@MichaReiser MichaReiser merged commit 0bc8426 into rome:main Aug 9, 2022
@IWANABETHATGUY IWANABETHATGUY deleted the fix/rome-ast-grammar-error branch August 9, 2022 06:29
IWANABETHATGUY added a commit to IWANABETHATGUY/tools that referenced this pull request Aug 22, 2022
@IWANABETHATGUY
fix(playground): 🐛 fix rome ast grammar error (rome#3032)
ec75d5b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IWANABETHATGUY @MichaReiser
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载