This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): use camel case for class members #3037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
cbed0cb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3e403fc6.tools-8rn.pages.dev |
| Branch Preview URL: | https://fix-usecamelcase-class-metho.tools-8rn.pages.dev |
leops
approved these changes
Aug 10, 2022
| Some(JsRuleAction { | ||
| category: ActionCategory::Refactor, | ||
| applicability: Applicability::Always, | ||
| message: markup! { "Rename this symbol to camel case" }.to_owned(), |
There was a problem hiding this comment.
Nit: this message could be improved slightly by inspecting the surroundings of the binding node to guess a more precise term than "symbol" like "variable", "method", "function", "parameter" ...
d497be5 to
0fe5ab1
Compare
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
* correctly identify non-camel case named class methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3028.
Test Plan