This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat: 🎸 finish codemirror formatter ir #3009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
reviewed
Aug 4, 2022
| </button> | ||
| <pre className="h-screen overflow-scroll">{formatter_ir}</pre> | ||
| <CodeMirror | ||
| value={formatter_ir} |
There was a problem hiding this comment.
Does the same grammar work for prettiers ir too?
There was a problem hiding this comment.
If our IR is the same as prettier's, then it should work.
There was a problem hiding this comment.
Prettier's IR uses a very similar structure: ( and ) for an element, [] for a sequence of children.
There was a problem hiding this comment.
I will replace in next pr
2022-08-05.2.56.16.mov |
|
Source code is here https://github.com/IWANABETHATGUY/codemirror-rome-formatter-ir, feel free to review it. |
92f4404 to
151112a
Compare
|
Neat, I love it! |
MichaReiser
approved these changes
Aug 6, 2022
IWANABETHATGUY
added a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 10, 2022
IWANABETHATGUY
added a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan